[PATCH] D78352: [MLIR] Add GenericAtomicRMWOp.

Frank Laub via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 11:21:35 PDT 2020


flaub accepted this revision.
flaub added a comment.

LGTM



================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:511
+  return success();
+}
+
----------------
Could we add a check that all the ops in the region are side-effect free?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78352/new/

https://reviews.llvm.org/D78352





More information about the llvm-commits mailing list