[PATCH] D78493: [ARM] Don't shrink STM.W to unpredictable STM.N with writeback

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 10:48:24 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb2SizeReduction.cpp:525
 
+    // STM with writeback that stores the base register is unpredictable.
+    Register BaseReg = MI->getOperand(0).getReg();
----------------
It's probably worth reorganizing the comments here to clarify: tSTMIA_UPD the only 16-bit STM.  So the Thumb2 instruction is fine, but the rewritten one would be unpredictable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78493/new/

https://reviews.llvm.org/D78493





More information about the llvm-commits mailing list