[PATCH] D78475: [CallSite removal][ExecutionEngine] Use CallBase in the Interpreter. NFC

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin accepted this revision.
mtrofin added a comment.
This revision is now accepted and ready to land.

lgtm, some nits



================
Comment at: llvm/lib/ExecutionEngine/Interpreter/Execution.cpp:1139
+  //
+  BasicBlock::iterator me(&I);
+  BasicBlock *Parent = I.getParent();
----------------
"me" -> "Me"?


================
Comment at: llvm/lib/ExecutionEngine/Interpreter/Execution.cpp:1164
   uint16_t pNum = 1;
-  for (CallSite::arg_iterator i = SF.Caller.arg_begin(),
-         e = SF.Caller.arg_end(); i != e; ++i, ++pNum) {
+  for (auto i = SF.Caller->arg_begin(), e = SF.Caller->arg_end(); i != e;
+       ++i, ++pNum) {
----------------
Can the iterator be capitalized? Since there's an "I", how about ArgI?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78475/new/

https://reviews.llvm.org/D78475