[PATCH] D57779: [SLP] Add support for throttling.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 03:11:23 PDT 2020


nikic added a comment.

@xbolva00 Numbers: http://llvm-compile-time-tracker.com/compare.php?from=f52e0507574b4fd84dc4674536f5dfbab396c0f6&to=8183667111e08c670d32f1aa9d204cff3427037f&stat=instructions

Only benchmark with a significant change is ClamAV at +0.2%. @dtemirbulatov If you want to look into some files, interesting ones may be (part of test-suite):

  CMakeFiles/clamscan.dir/shared_sha256.c.o 	3013M 	3113M (+3.31%)
  CMakeFiles/7zip-benchmark.dir/CPP/7zip/Archive/Common/OutStreamWithCRC.cpp.o 	372M 	391M (+5.03%)

Not surprised to see shared_sha256.c here, it's a known pathological case for SLP (https://bugs.llvm.org/show_bug.cgi?id=45269).

Overall I think the change is fine from compile-time perspective.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57779/new/

https://reviews.llvm.org/D57779





More information about the llvm-commits mailing list