[PATCH] D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC

Mon Apr 20 02:39:08 PDT 2020

ldionne added a comment.

In D77370#1978139 <https://reviews.llvm.org/D77370#1978139>, @sbc100 wrote:

> In D77370#1977747 <https://reviews.llvm.org/D77370#1977747>, @ldionne wrote:
>
> > In light of this, would you (or someone else) be opposed to removing `LIBCXXABI_ENABLE_PIC`?
>
>
> I think the problem is that there are other platforms/targets who want/expect the static library to built with PIC, at least for this particular library.  I think you might find that you break them if you revert to the cmake defaults here.

In that case, I think the problem stems from trying to build the runtimes alongside the rest of LLVM, instead of separately as they ought to (either manually or using the runtimes build). I'll put up a patch to remove the option.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77370/new/

https://reviews.llvm.org/D77370