[PATCH] D78453: [llvm][Z3][NFC] Improve mkBitvector performance

[Gábor Horváth via Phabricator via llvm-commits]

xazax.hun added a comment.

In D78453#1991384 <https://reviews.llvm.org/D78453#1991384>, @steakhal wrote:

> In D78453#1991294 <https://reviews.llvm.org/D78453#1991294>, @xazax.hun wrote:
>
> > Mostly looks good to me. I do believe that this is an optimization but it would be nice to have a small benchmark :) In case it is too much work, I do not insist though.
>
>
> I'm curious too.
>
> Though I'm not sure how to accomplish that. AFAIK you measured such.
>  How should I measure this?
>  Should I use eg. the Clang SA and analyze different projects? (which, how many, etc)
>  Wouldn't have this method introduce too much noise?
>  Or should I measure this by a microbenchmark?
>
> I'm really in favor of the microbenchmark approach.


It is interesting to see if using Z3 (not just the crosscheck) on some projects will show any difference. I would start with this as this might be the easiest to set up. If we do not see any difference on two or three projects we can try doing some microbenchmarks instead. In a microbenchmark, you can just call `mkBitvector` with random values (a good question is how to choose the distribution of the types).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78453/new/

https://reviews.llvm.org/D78453