[PATCH] D78361: [yaml2obj] - Verify that sections are sorted by their file offsets when creating segments.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:419
+## Check that we require sections in a program header
+## declaration to be sorted by the file offset.
+# RUN: not yaml2obj --docnum=5 %s -o %t5 2>&1 | \
----------------
the file offset -> their offsets

(sections only have one kind of offset field defined, so I don't think you need to say "file")


================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:441
+    VAddr:  0x1000
+## Case 2: there is nothing wrong with this segment. We have it to show that
+##         we report correct program header indices in error messages.
----------------
This isn't really a "Case", as that implies it's actually something that is testing functionality itself. I'd just get rid of the Case labels in this test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78361/new/

https://reviews.llvm.org/D78361