[PATCH] D78397: [mlir][Transforms] Add pass to perform sparse conditional constant propagation

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In D78397#1990753 <https://reviews.llvm.org/D78397#1990753>, @fhahn wrote:

> Viewed very simplistically, they only require the following from an IR:  SSA, a way to traverse a function along CFG edges, a way to simplify instructions and a way to replace values. Do you think it would be feasible to provide some kind of interface to abstract those and then work towards sharing the implementations of the underlying algorithms between LLVM & MLIR? Or is the plan to duplicate various passes from LLVM also in MLIR?


That'll be an interesting and likely recurring question moving forward. I wonder however if when applicable LLVM would be OK to take a slow-down from generalizing passes to MLIR and going through interfaces for the sake of sharing the implementation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78397/new/

https://reviews.llvm.org/D78397