[PATCH] D78423: [MLIR] NFC affine for op tiling cleanup / utility rename

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 18 11:17:53 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/Affine/Transforms/LoopTiling.cpp:98
   for (unsigned i = 0; i < width; i++) {
-    auto lbOperands = origLoops[i].getLowerBoundOperands();
-    auto ubOperands = origLoops[i].getUpperBoundOperands();
-    SmallVector<Value, 4> newLbOperands(lbOperands);
-    SmallVector<Value, 4> newUbOperands(ubOperands);
+    newLbOperands = origLoops[i].getLowerBoundOperands();
+    newUbOperands = origLoops[i].getUpperBoundOperands();
----------------
Can you just use OperandRange instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78423/new/

https://reviews.llvm.org/D78423





More information about the llvm-commits mailing list