[PATCH] D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases

Anchu Rajendran S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 18 07:00:38 PDT 2020


anchu-rajendran created this revision.
anchu-rajendran added reviewers: tskeith, klausler.
anchu-rajendran added projects: Flang, LLVM.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: DavidTruby.
Herald added a reviewer: sscalpone.
Herald added a subscriber: llvm-commits.
anchu-rajendran added a comment.

@klausler, Current implementation of C877 may change and may depend on the modifications which will be made by you. I will make changes accordingly after your changes are merged.


- C876, C877 checks are implemented.
- Modified pre-fir-tree02.f90, block-data01.f90 and data01.f90 as they were not conforming to C876

The only semantic check for DATA statement that remains to be implemented is C879 (which is not properly checked  because of a bug:  ```IsConstantExpr``` is  not identifying the fields of named constant derived type variables as constants.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78424

Files:
  flang/lib/Semantics/check-data.cpp
  flang/lib/Semantics/check-data.h
  flang/test/Lower/pre-fir-tree02.f90
  flang/test/Semantics/block-data01.f90
  flang/test/Semantics/data01.f90
  flang/test/Semantics/data04.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78424.258516.patch
Type: text/x-patch
Size: 11364 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200418/f453e7a9/attachment.bin>


More information about the llvm-commits mailing list