[llvm] 034e8d5 - [SCCP] Drop unused early exit from visitReturnInst (NFC).

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 18 06:08:34 PDT 2020


Author: Florian Hahn
Date: 2020-04-18T13:52:41+01:00
New Revision: 034e8d58a800608c5ee2b95c4b132b546a82d4df

URL: https://github.com/llvm/llvm-project/commit/034e8d58a800608c5ee2b95c4b132b546a82d4df
DIFF: https://github.com/llvm/llvm-project/commit/034e8d58a800608c5ee2b95c4b132b546a82d4df.diff

LOG: [SCCP] Drop unused early exit from visitReturnInst (NFC).

There are no lattice values associated with return instructions
directly. They will never get marked as overdefined.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/SCCP.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/SCCP.cpp b/llvm/lib/Transforms/Scalar/SCCP.cpp
index f5b3ebd1a002..6bb19383964c 100644
--- a/llvm/lib/Transforms/Scalar/SCCP.cpp
+++ b/llvm/lib/Transforms/Scalar/SCCP.cpp
@@ -746,11 +746,6 @@ void SCCPSolver::visitPHINode(PHINode &PN) {
 void SCCPSolver::visitReturnInst(ReturnInst &I) {
   if (I.getNumOperands() == 0) return;  // ret void
 
-  // ResolvedUndefsIn might mark I as overdefined. Bail out, even if we would
-  // discover a concrete value later.
-  if (isOverdefined(ValueState[&I]))
-    return (void)markOverdefined(&I);
-
   Function *F = I.getParent()->getParent();
   Value *ResultOp = I.getOperand(0);
 


        


More information about the llvm-commits mailing list