[PATCH] D77038: Fix bug in BitVector and SmallBitVector DenseMap hashing

Brad Moody via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 18:46:50 PDT 2020


bmoody added a comment.

I'm unsure about adding a test that BitVector and SmallBitVector hash exactly the same way, because in principle I think this is a consequence of implementation details and not a property that we actually want per se.  In future the implementations might diverge such that they must hash differently (or at least, that it would be convenient for them to hash differently), and IMO that would be ok.  But I'm willing to add the test if you disagree.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77038/new/

https://reviews.llvm.org/D77038





More information about the llvm-commits mailing list