[PATCH] D78403: Infer alignment of loads with unspecified alignment in IR/bitcode parsing.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/AsmParser/Parser.h:31
 
+typedef llvm::function_ref<void (Module*)> DataLayoutCallbackTy;
+
----------------
The type for the callback is strange to me, this allows basically any modification of the Module during the callback, can't we just pass an `Optional<DataLayout> override_datalayout` in the parsing functions?


================
Comment at: llvm/tools/opt/opt.cpp:123
 static cl::opt<bool>
+NoUpgradeDebugInfo("disable-upgrade-debug-info",
+                   cl::desc("Generate invalid output"), cl::ReallyHidden);
----------------
How is it related to the data layout thing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78403/new/

https://reviews.llvm.org/D78403