[PATCH] D78395: [llvm][NFC][CallSite] Remove CallSite from Evaluator.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 16:59:27 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/Evaluator.h:90
+  Function *getCalleeWithFormalArgs(CallBase &CB,
+                                    SmallVector<Constant *, 8> &Formals);
+
----------------
Can we change these to SmallVectorImpl<Constant *>& while we're already touching these lines? No point in forcing a specific size on the caller or repeating it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78395/new/

https://reviews.llvm.org/D78395





More information about the llvm-commits mailing list