[PATCH] D78179: [Darwin] Fix symbolization for recent simulator runtimes.

Fri Apr 17 12:26:11 PDT 2020

delcypher marked 4 inline comments as done.
delcypher added inline comments.

================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.h:38
   bool SymbolizeData(uptr addr, DataInfo *info) override;
+  void LateInitialize() override;

----------------
yln wrote:
> delcypher wrote:
> > kubamracek wrote:
> > > I don't see a virtual LateInitialize in SymbolizerTool... is this supposed to not be an "override"?
> > Please see the patch that this patch depends on: https://reviews.llvm.org/D78178
> Just a quick question: will the principled resolution (where we modify the env only for posix_spawn, but not in our own process) require this as well.  If not, is the plan to remove it again?
The principled resolution does not depend on https://reviews.llvm.org/D78178.
However, I'm abandoning the principled resolution due to complexity involved in copying the environment and modifying the copy. I had it all implemented but it needs a lot of clean up for adoption in open source which I don't have time to do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78179/new/

https://reviews.llvm.org/D78179