[PATCH] D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D77821#1988999 <https://reviews.llvm.org/D77821#1988999>, @sscalpone wrote:

> Yes, @clementval, I understood your comment, and it got me thinking about the structure of the compiler's evaluation of OpenMP semantics.  Looking at the code, I believe the assert at line 6517 will trigger if the collapse value is greater than the loop nest. Unfortunately the check for collapse(n) cannot be moved earlier to the structure checker because symbols have not yet been resolved so 'n' cannot be evaluated.  I've talked with @ichoyjx about keeping the symbol resolution here but moving the association of attributes to semantics, at which time all of the required information can be available.
>
> In the meantime, this change is a reasonable workaround to prevent the assertion until the code is restructured.


Yeah it makes sense


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77821/new/

https://reviews.llvm.org/D77821