[PATCH] D78383: [LVI] Use Optional instead of out parameter (NFC)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 10:14:55 PDT 2020


nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: lib/Analysis/LazyValueInfo.cpp:839
+    return None;
+  ValueLatticeElement TrueVal = *OptTrueVal;
 
----------------
My C++ foo is weak... would the proper way to write this without copying the lattice value be `TrueValue = *std::move(OptTrueVal)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78383/new/

https://reviews.llvm.org/D78383





More information about the llvm-commits mailing list