[PATCH] D78005: [yaml2obj] - Reimplement how tool calculates file and memory sizes of segments.

Fri Apr 17 05:54:47 PDT 2020

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:452
+##         the .bar section because of the "ShOffset" property.
+##         Document we report an error for such case.
+  - Type:  PT_LOAD
----------------
jhenderson wrote:
> "Document" implies to me that we are just showing the current behaviour and that it doesn't matter if it changes. I don't think that's right. It should be "Check that". Also "such a case".
I used "Document" because I am not sure it is not a bug: I am not sure that Sh* properties should affect on how do we create program headers.
"Sh*" properties were initially introduced to override values. E.g. ShSize described as "This can be used to override the sh_size field. It does not affect the content written.". Perhaps we set `ShOffset` too early and should not report an error for this case. Hence "Document"..

This test is a part of D78361 now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78005/new/

https://reviews.llvm.org/D78005