[PATCH] D76149: [AssumeBundles] Use assume bundles in isKnownNonZero

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for all the changes! The patch looks good to me with respect to my comments, but I think it would be good for someone else to have another look as well.



================
Comment at: llvm/include/llvm/Analysis/AssumeBundleQueries.h:106
+/// ArgValue is optionally an argument of the attribute.
+/// for example if we know that %P has an alignment of at least 4.
+/// AttrKind will be Attribute::Alignment
----------------
nit: For example ..... of at least for:
* AttrKind will...
* WasOn will be 
* argValue will be...


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:703
+
   for (auto &AssumeVH : Q.AC->assumptionsFor(V)) {
     if (!AssumeVH)
----------------
Just a side note: it would be good to unify the assumption handling for both variants :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76149/new/

https://reviews.llvm.org/D76149