[PATCH] D78340: [Flang] fix dependenvy issues after D78215

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 3 inline comments as done.
clementval added inline comments.


================
Comment at: flang/lib/Evaluate/CMakeLists.txt:32
   FortranDecimal
+  FortranSemantics
   FortranParser
----------------
ChinouneMehdi wrote:
> You are reintroducing a cycle-dependency between FortranEvaluate and FortranSemantics, and in addition FortranEvaluate doesn't call any function from FortranSemantics.
On my system there is a linking problem without this. 


================
Comment at: flang/lib/Optimizer/Dialect/CMakeLists.txt:9
   FIROpsIncGen
+  FIRSupport
 
----------------
ChinouneMehdi wrote:
> FortranSupport is already declared as a dependency, why!
Compile time dependency and link time dependency are not the same. 


================
Comment at: flang/lib/Optimizer/Support/CMakeLists.txt:6-7
 
+  DEPENDS
+  ${dialect_libs}
   LINK_LIBS
----------------
ChinouneMehdi wrote:
> Same here!
This is needed as this is a compile time dependency as well. Before your patch everything was compiling fine. But not after it. Those change are fixing the problem your introduced on the system I use at least. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340