[PATCH] D77523: Add CanonicalizeFreezeInLoops pass

Sanne Wouda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 04:50:05 PDT 2020


sanwou01 added a comment.

I can report that in our testing on SPEC 2017, this pass fixes the regression to mcf introduced with D76483 <https://reviews.llvm.org/D76483>.

This patch gives an uplift of 1.5% on mcf_r; other benchmarks in SPEC 2017 intrate are between +0.4% and -0.2%.

We also looked into what seemed to be a regression of at most 1.5% on xalancbmk on some different hardware but this seems to be within normal fluctuations of this particular benchmark, with no changes apparent in the relevant (performance critical) areas of the code.

>From a performance point of view this is good to go, but I'd like to leave an LGTM to others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77523/new/

https://reviews.llvm.org/D77523





More information about the llvm-commits mailing list