[PATCH] D77805: [obj2yaml] - Teach obj2yaml to dump SHT_NOBITS sections when dumping program headers.

[George Rimar via Phabricator via llvm-commits]

grimar updated this revision to Diff 258286.
grimar marked 3 inline comments as done.
grimar added a comment.

- Addressed review comments.

Ready for review:

> I feel that the dependency can be reversed, i.e. D77652 <https://reviews.llvm.org/D77652> will depend on D77805 <https://reviews.llvm.org/D77805>.

Done.

>> In D77805#1972126 <https://reviews.llvm.org/D77805#1972126>, @grimar wrote:
>>  I think I've found an issue in yaml2obj revealed by the test case I'd like to add here.
>>  I'll investigate it in my tomorrow and update this patch after.
> 
> It needs D78005 <https://reviews.llvm.org/D78005> to be landed to proceed.

Let's go without an additional test case for now, the issue I was talking about is
related to trailing multiple SHT_NOBITS sections (fixed in D78005 <https://reviews.llvm.org/D78005>).
We can add it later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77805/new/

https://reviews.llvm.org/D77805

Files:
  llvm/test/tools/obj2yaml/program-headers.yaml
  llvm/tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77805.258286.patch
Type: text/x-patch
Size: 4661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200417/baecb1ff/attachment.bin>