[PATCH] D78356: [flang] Use a better definition for ATTRIBUTE_UNUSED

[مهدي شينون (Mehdi Chinoune) via Phabricator via llvm-commits]

ChinouneMehdi created this revision.
ChinouneMehdi added a reviewer: Flang.
ChinouneMehdi created this object with edit policy "Members of Project: Flang".
ChinouneMehdi added a project: Flang.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

ATTRIBUTE_UNUSED wasn't defined with MSVC.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78356

Files:
  flang/include/flang/Common/idioms.h


Index: flang/include/flang/Common/idioms.h
===================================================================
--- flang/include/flang/Common/idioms.h
+++ flang/include/flang/Common/idioms.h
@@ -98,9 +98,7 @@
   } \
   template <typename A> constexpr bool T{class_trait_ns_##T::trait_value<A>()};
 
-#if !defined ATTRIBUTE_UNUSED && (__clang__ || __GNUC__)
-#define ATTRIBUTE_UNUSED __attribute__((unused))
-#endif
+#define ATTRIBUTE_UNUSED [[maybe_unused]]
 
 // Define enum class NAME with the given enumerators, a static
 // function EnumToString() that maps enumerators to std::string,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78356.258281.patch
Type: text/x-patch
Size: 590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200417/43d17bdf/attachment-0001.bin>