[PATCH] D78332: Fix interaction of static plugins with -DLLVM_LINK_LLVM_DYLIB=ON.

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 01:03:01 PDT 2020


serge-sans-paille added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:886
     # object library as of now
-    add_llvm_library(${name} OBJECT ${ARG_UNPARSED_ARGUMENTS})
+    add_llvm_component_library(${name} OBJECT ${ARG_UNPARSED_ARGUMENTS})
     target_compile_definitions(${name} PRIVATE LLVM_${name_upper}_LINK_INTO_TOOLS)
----------------
Conceptually, do we want Extensions to be considered as component?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78332/new/

https://reviews.llvm.org/D78332





More information about the llvm-commits mailing list