[PATCH] D78343: [CallSite remova][Attributor] Replaces use of CallSite with CallBase. NFC

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 23:14:43 PDT 2020


mtrofin accepted this revision.
mtrofin added a comment.
This revision is now accepted and ready to land.

LGTM, one nit, sorry I only noticed it now.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1830
 
-    for (int i = 0, e = CS.getNumArgOperands(); i < e; i++) {
+    for (int i = 0, e = CB->getNumArgOperands(); i < e; i++) {
 
----------------
mtrofin wrote:
> Can we capitalize i and e - the lines are already changed anyway (change size stays almost the same)
Sorry, just saw it late - and it's super-nitty; can we ++I (while at it)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78343/new/

https://reviews.llvm.org/D78343





More information about the llvm-commits mailing list