[PATCH] D78322: [CallSite removal][IPO] Move AbstractCallSite to its own header and change it to use CallBase instead of CallSite. NFCI

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D78322#1987667 <https://reviews.llvm.org/D78322#1987667>, @dblaikie wrote:

> In D78322#1987561 <https://reviews.llvm.org/D78322#1987561>, @craig.topper wrote:
>
> > In D78322#1987472 <https://reviews.llvm.org/D78322#1987472>, @dblaikie wrote:
> >
> > > Looks good - I'd probably have done it differently (waited until all the CallSite uses were eliminated, deleted that code from CallSite.h, then renamed CallSite.h to AbstractCallSite.h) because I /think/ it'd present easier/better revision history, but that's only based on /really/ vague guesses about how smart/not-smart the change tracking stuff is - in any case, dealer's choice :)
> >
> >
> > That's good point. I mainly did it this way so I could remove the include of CallSite.h from Attributor so the compiler could tell me where all the uses of CallSite were.
>
>
> Yeah, figured it might be something like that - if you find it a good way to make progress, go for it. Super up to you :)


Well removing the include didn't really help. Must be transitively included somewhere. So given that I'm going to just do the change to use CallBase in the implementation and not split the header.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78322/new/

https://reviews.llvm.org/D78322