[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ExpandVectorPredication.h:1
+//===----- ExpandVectorPredication.h - Expand vector predication --===//
+//
----------------
C++ mode comment


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:197-198
+    // Division operators need a safe divisor on masked-off lanes (1.0)
+    case Instruction::FDiv:
+    case Instruction::FRem:
+    case Instruction::UDiv:
----------------
Shouldn't be true for FP divisions


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:271-272
+
+  LLVM_DEBUG(dbgs() << "NEW vlen: " << *FullVL << '\n');
+  LLVM_DEBUG(dbgs() << "NEW mask: " << *NewMaskParam << '\n');
+
----------------
Combine into one LLVM_DEBUG


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203