[PATCH] D78309: [LLVM] Remove wrong DBG_VALUE instruction with one operand in AArch64 test case

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 13:56:55 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/branch-target-enforcement.mir:343
     ; CHECK-NOT: HINT
-    ; CHECK: DBG_VALUE
     ; CHECK: frame-setup PACIASP
----------------
I think this is breaking the point of the test: it's specifically supposed to be checking that DBG_VALUE instructions don't confuse the transform.  (So the test doesn't really care what the DBG_VALUE is, but it does care that one exists.)

Probably not too important, but still.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78309/new/

https://reviews.llvm.org/D78309





More information about the llvm-commits mailing list