[PATCH] D78263: [PowerPC][AIX] ByVal formal argument support: passing on the stack

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm accepted this revision.
cebowleratibm added a comment.
This revision is now accepted and ready to land.

I think the review title "ByVal formal argument support: passing on the stack" implies that it covers the reg/stack split case.  I noted you described it better in the review description.  I think a slightly more descriptive abstract would be useful for the commit message.

I noted that test_byval_mem4 could have been defined for 64-bit, however 32-bit would emit an error.  I expect you plan to follow up with another patch to handle the reg/stack split case, just be sure to add the definition of this function for that case when you do.

I think this one looks pretty straight forward.  LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78263/new/

https://reviews.llvm.org/D78263