[PATCH] D78135: [MachineDebugify] Insert synthetic DBG_VALUE instructions

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 258131.
vsk added a comment.

One more (and I think the last!) update to the testing strategy.

Instead of limiting -mir-debugify to inserting DBG_VALUEs after register
definitions, have it insert DBG_VALUEs after /every/ real instruction. When a
register def isn't available, just describe a constant.

Also, sometimes MIR tests are written with skeletal (or no) IR. We still want
-mir-debugify test coverage in these cases, so force the IR debugify pass to
describe at least one variable per function.

This uncovers a few more CodeGen-difference-with-debug issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78135/new/

https://reviews.llvm.org/D78135

Files:
  llvm/lib/CodeGen/MachineDebugify.cpp
  llvm/lib/Transforms/Utils/Debugify.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/constant-mir-debugify.mir
  llvm/test/CodeGen/AArch64/GlobalISel/legalize-phi-insertpt-decrement.mir
  llvm/test/CodeGen/AArch64/GlobalISel/phi-mir-debugify.mir
  llvm/test/CodeGen/Generic/MIRDebugify/locations-and-values.mir
  llvm/test/CodeGen/Generic/MIRDebugify/locations.mir
  llvm/test/DebugInfo/debugify.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78135.258131.patch
Type: text/x-patch
Size: 20586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200416/590bf992/attachment-0001.bin>