[PATCH] D77353: [WebAssembly] Add DW_OP_WASM_location_int

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 12:50:14 PDT 2020


aardappel added a comment.

@yurydelendik one thing about your patch: the variadic argument was previously declared as `SignedSizeLEB` and emitted with `emitSigned`, yet your new code reads it as `getULEB128` and stores it in an array of `uint64_t` (which we can't change since its shared code). It doesn't matter much for the current use case, but we might want to be consistent about this storing signed or unsigned values? I see value in it being signed for future use cases, but given the existing `DWARFExpression` code it may well have to be unsigned.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77353/new/

https://reviews.llvm.org/D77353





More information about the llvm-commits mailing list