[PATCH] D78302: [mlir][ods] Add materialize derived attribute method

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Interfaces/DerivedAttributeOpInterface.td:35
+    InterfaceMethod<
+      /*desc=*/[{Materializes the derived attributes. Returns null attribute
+                 where unable to materialize a derived attribute as attribute.}],
----------------
Can you indent this like the others?


================
Comment at: mlir/test/lib/Dialect/Test/TestPatterns.cpp:146
+    for (auto d : dAttr) {
+      dOp.emitRemark(llvm::formatv("{0} = {1}", d.first.strref(), d.second));
+    }
----------------
Seems easier to just do:

emitRemark() << d.first << " = " << d.second;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78302/new/

https://reviews.llvm.org/D78302