[PATCH] D78309: [LLVM] Remove wrong DBG_VALUE instruction with one operand in AArch64 test case

[Jaydeep Chauhan via Phabricator via llvm-commits]

Jac1494 created this revision.
Jac1494 added reviewers: dsanders, eli.friedman, jmorse, vsk.
Jac1494 added a project: LLVM.
Herald added subscribers: danielkiss, kristof.beyls.
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM. I'll remove the workaround in mir-strip-debug once this lands

Thanks


AArch64 test case llvm/test/CodeGen/AArch64/branch-target-enforcement.mir is checking for invalid  DBG_VALUE instruction with one operand(`DBG_VALUE $lr`). And this DBG_VALUE instruction is echoed from test case it self only.

Correct format of DBG_VALUE is given in below link:
https://llvm.org/docs/SourceLevelDebugging.html#variable-locations-in-instruction-selection-and-mir


https://reviews.llvm.org/D78309

Files:
  llvm/test/CodeGen/AArch64/branch-target-enforcement.mir


Index: llvm/test/CodeGen/AArch64/branch-target-enforcement.mir
===================================================================
--- llvm/test/CodeGen/AArch64/branch-target-enforcement.mir
+++ llvm/test/CodeGen/AArch64/branch-target-enforcement.mir
@@ -340,11 +340,9 @@
 
     ; CHECK-LABEL: name: debug_ptr_auth
     ; CHECK-NOT: HINT
-    ; CHECK: DBG_VALUE
     ; CHECK: frame-setup PACIASP
     ; CHECK-NOT: HINT
     ; CHECK: RETAA
-    DBG_VALUE $lr
     frame-setup PACIASP implicit-def $lr, implicit killed $lr, implicit $sp
     frame-setup CFI_INSTRUCTION negate_ra_sign_state
     early-clobber $sp = frame-setup STRXpre killed $lr, $sp, -16 :: (store 8 into %stack.0)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78309.258057.patch
Type: text/x-patch
Size: 682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200416/e034990a/attachment.bin>