[PATCH] D78249: Reland "[codeview] Reference types in type parent scopes"

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:335
+std::string
+CodeViewDebug::formatNestedName(ArrayRef<StringRef> QualifiedNameComponents,
+                                StringRef TypeName) {
----------------
amccarth wrote:
> What's the advantage of making this file-scope static function into a method?  It doesn't seem to access any member variables.
> 
> If you just want to group it with related methods, can it be class-static or at least const?
> 
> Making this one non-static seems to ripple through the next two methods as well.
I think you're right, this one doesn't need to be a method, it can remain a static helper. The other ones call `collectParentScopes` which does access a member now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78249/new/

https://reviews.llvm.org/D78249