[llvm] ee66b5b - Pass.h/cpp - cleanup includes and forward declaration. NFC.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 05:15:46 PDT 2020


Author: Simon Pilgrim
Date: 2020-04-16T13:15:31+01:00
New Revision: ee66b5b0da7e54124b87268d33d9fad7a4a93b87

URL: https://github.com/llvm/llvm-project/commit/ee66b5b0da7e54124b87268d33d9fad7a4a93b87
DIFF: https://github.com/llvm/llvm-project/commit/ee66b5b0da7e54124b87268d33d9fad7a4a93b87.diff

LOG: Pass.h/cpp - cleanup includes and forward declaration. NFC.

Remove unused BasicBlock forward declaration from Pass.h and Attributes/BasicBlock includes from Pass.cpp
Add BasicBlock forward declaration to UnifyFunctionExitNodes.h which was relying on Pass.h

Added: 
    

Modified: 
    llvm/include/llvm/Pass.h
    llvm/include/llvm/Transforms/Utils/UnifyFunctionExitNodes.h
    llvm/lib/IR/Pass.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Pass.h b/llvm/include/llvm/Pass.h
index 5ed4ca4f6157..b0af15a7dab2 100644
--- a/llvm/include/llvm/Pass.h
+++ b/llvm/include/llvm/Pass.h
@@ -34,7 +34,6 @@ namespace llvm {
 
 class AnalysisResolver;
 class AnalysisUsage;
-class BasicBlock;
 class Function;
 class ImmutablePass;
 class Module;

diff  --git a/llvm/include/llvm/Transforms/Utils/UnifyFunctionExitNodes.h b/llvm/include/llvm/Transforms/Utils/UnifyFunctionExitNodes.h
index b8a4fe72ea25..f1789ed2a1b1 100644
--- a/llvm/include/llvm/Transforms/Utils/UnifyFunctionExitNodes.h
+++ b/llvm/include/llvm/Transforms/Utils/UnifyFunctionExitNodes.h
@@ -22,6 +22,8 @@
 
 namespace llvm {
 
+class BasicBlock;
+
 struct UnifyFunctionExitNodes : public FunctionPass {
   BasicBlock *ReturnBlock = nullptr;
   BasicBlock *UnwindBlock = nullptr;

diff  --git a/llvm/lib/IR/Pass.cpp b/llvm/lib/IR/Pass.cpp
index dbdbbf4cf35e..893cf2fe0b6b 100644
--- a/llvm/lib/IR/Pass.cpp
+++ b/llvm/lib/IR/Pass.cpp
@@ -14,8 +14,6 @@
 
 #include "llvm/Pass.h"
 #include "llvm/Config/llvm-config.h"
-#include "llvm/IR/Attributes.h"
-#include "llvm/IR/BasicBlock.h"
 #include "llvm/IR/Function.h"
 #include "llvm/IR/IRPrintingPasses.h"
 #include "llvm/IR/LLVMContext.h"


        


More information about the llvm-commits mailing list