[PATCH] D78208: [DebugInfo] Report the format of the DWARF64 sections.

Thu Apr 16 03:23:26 PDT 2020

ikudrin marked an inline comment as done.
ikudrin added a comment.

Thanks, @jhenderson! I'll address the comments in the next update.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp:20-21
+     << " length = " << format("0x%08" PRIx64, getLength());
+  if (getFormat() == dwarf::DWARF64)
+    OS << " format = DWARF64";
+  OS << " version = " << format("0x%04x", getVersion());
----------------
jhenderson wrote:
> I wonder if it would make sense to print DWARF32 for when we're not using DWARF64? That would make the output more regular and parseable. What do you think?
I thought about that, but the changes in the output would make it incompatible with lots of existing tests and, probably, might affect some external tools.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78208/new/

https://reviews.llvm.org/D78208