[PATCH] D77946: [PowerPC] Don't use rldicl when targeting 32bit CPUs

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 16 02:49:31 PDT 2020


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for fixing this.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:5074
+def : Pat<(i32 (bitreverse i32:$A)), (RLDICL_32 RotateInsertByte1.Left, 0, 32)>;
+let Predicates = [In32BitMode] in
+def : Pat<(i32 (bitreverse i32:$A)), RotateInsertByte1.Left>;
----------------
These are the right predicates to use. Using `RLDICL` in 32-bit mode is at best unnecessary here and at worst not legal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77946/new/

https://reviews.llvm.org/D77946





More information about the llvm-commits mailing list