[PATCH] D78276: [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)

[Kan Shengchen via Phabricator via llvm-commits]

skan marked an inline comment as done.
skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1396
 
-  bool Rex = false;
-  emitPrefixImpl(CurOp, CurByte, Rex, MI, STI, OS);
+  bool HasREX = static_cast<bool>(emitPrefixImpl(CurOp, CurByte, MI, STI, OS));
 
----------------
craig.topper wrote:
> Why not return it as a bool from emitREXPrefix?
To myself, it seems more nature to return a `REX` ... . I am not sure if furture instruction's encoding will depends on the value of `REX`. Do you mean it is better to return `REX` as bool?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78276/new/

https://reviews.llvm.org/D78276