[PATCH] D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D77821#1985263 <https://reviews.llvm.org/D77821#1985263>, @jdoerfert wrote:

> In D77821#1984526 <https://reviews.llvm.org/D77821#1984526>, @sscalpone wrote:
>
> > In all cases, the compiler must check that the expression used in collapse is positive.  Seems like overkill to create a new expr parser to catch a subset of this check.
> >
> > The change looks good. Thanks.
>
>
> I mentioned this before, the change addresses this TODO which should be removed or modified accordingly:
>
>   // TODO: This assumes that the do-loops association for collapse/ordered
>   //       clause has been performed (the number of nested do-loops >= n).
>


I have updated the comment. I'll have a look to address the semantic check regarding the loop association. Nevertheless, the structure check for OpenMP is currently done after the name resolution so the error is only caught after this is executed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77821/new/

https://reviews.llvm.org/D77821