[PATCH] D74651: Add IR constructs for inalloca replacement llvm.call.setup

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

We still need a LangRef patch at some point.

I suspect we might end up tweaking the signature of llvm.call.setup, based on the llvm-dev discussion, but we can experiment in-tree, I guess.



================
Comment at: llvm/lib/IR/Verifier.cpp:1674
+  if (Attrs.hasAttribute(Attribute::Preallocated)) {
+    Assert(Attrs.getPreallocatedType() ==
+               cast<PointerType>(Ty)->getElementType(),
----------------
Do you need to check `Attrs.getPreallocatedType()->isSized()`, or something like that?  Or is that checked elsewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74651/new/

https://reviews.llvm.org/D74651