[PATCH] D71786: RFC: [Support] On Windows, add optional support for rpmalloc

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I think this is better as an off-by-default build configuration option. It also makes it easy for users with license concerns to avoid this dependency.

I basically thinks this looks good as is, but I want to get more guidance on what our policies on third party code are.



================
Comment at: llvm/lib/Support/rpmalloc/LICENSE:24
+
+For more information, please refer to <http://unlicense.org>
----------------
My understanding is that lawyers do not like one-off licenses. However, I think there is a pretty clear case that rpmalloc is not critical functionality to LLVM, it is an implementation of a well-defined interface: malloc, and if we discover license complications down the road, we can always remove it without removing critical functionality. And if anyone finds this worrying today, they do not need to enable the rpmalloc build mode.

So, that is my non-authoritative, "not legal advice" rationalization that this should be OK. And, you did put all the code in the rpmalloc directory. So, I think this is fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786