[PATCH] D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D77821#1984526 <https://reviews.llvm.org/D77821#1984526>, @sscalpone wrote:

> In all cases, the compiler must check that the expression used in collapse is positive.  Seems like overkill to create a new expr parser to catch a subset of this check.
>
> The change looks good. Thanks.


I mentioned this before, the change addresses this TODO which should be removed or modified accordingly:

  // TODO: This assumes that the do-loops association for collapse/ordered
  //       clause has been performed (the number of nested do-loops >= n).




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77821/new/

https://reviews.llvm.org/D77821