[PATCH] D76863: Fix SelectionDAG Graph Printing on Windows

[Justice Adams via Phabricator via llvm-commits]

justice_adams added a comment.

@rnk

> So, if I want clang to overwrite some file, all I have to do is pass clang -mllvm -view-dag-combine1-dags and I can create a file with a name from the input source? That seems dangerous.

Currently, the dag printer will create a file with a name corresponding to the machine-function from the IR that it's representing with the graph, not the source file name. Forgive me if I misinterpreted this comment.

> Can you please move this code from the GraphWriter.h header to here?

Yes that seems to make sense. Does it make sense to move that into a separate patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76863/new/

https://reviews.llvm.org/D76863