[PATCH] D78147: [LICM] Try to merge debug locations when sinking

Wed Apr 15 13:13:45 PDT 2020

dblaikie added a comment.

In D78147#1984622 <https://reviews.llvm.org/D78147#1984622>, @davide wrote:

> Thank you all for the reviews.
>
>   commit 5f87415efc1e57587272944a5f9b6745e4474660 (HEAD -> master, origin/master, origin/HEAD)
>   Author: Davide Italiano <ditaliano at apple.com>
>   Date:   Wed Apr 15 12:28:34 2020 -0700
>  
>       [LICM] Try to merge debug locations when sinking.
>      
>       The current strategy LICM uses when sinking for debuginfo is
>       that of picking the debug location of one of the uses.
>       This causes stepping to be wrong sometimes, see, e.g. PR45523.
>      
>       This patch introduces a generalization of getMergedLocation(),
>       that operates on a vector of locations instead of two, and try
>       to merge all them together, and use the new API in LICM.
>      
>       <rdar://problem/61750950>
>  
>

If you can leave in the "Differential Revision: https://reviews.llvm.org/DXXXX" line in the commit message, it's handy for following from a commit to its review, and lets Phabricator auto-close reviews/point to the resulting commit.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78147/new/

https://reviews.llvm.org/D78147