[PATCH] D78166: [InlineSpiller] add assert about spills post terminators

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers updated this revision to Diff 257809.
nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added a comment.

- drop comment about llc flags, as per @efriedma


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78166/new/

https://reviews.llvm.org/D78166

Files:
  llvm/lib/CodeGen/InlineSpiller.cpp


Index: llvm/lib/CodeGen/InlineSpiller.cpp
===================================================================
--- llvm/lib/CodeGen/InlineSpiller.cpp
+++ llvm/lib/CodeGen/InlineSpiller.cpp
@@ -945,6 +945,9 @@
 /// insertSpill - Insert a spill of NewVReg after MI.
 void InlineSpiller::insertSpill(unsigned NewVReg, bool isKill,
                                  MachineBasicBlock::iterator MI) {
+  // Spill are not terminators, so inserting spills after terminators will
+  // violate invariants in MachineVerifier.
+  assert(!MI->isTerminator() && "Inserting a spill after a terminator");
   MachineBasicBlock &MBB = *MI->getParent();
 
   MachineInstrSpan MIS(MI, &MBB);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78166.257809.patch
Type: text/x-patch
Size: 673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200415/8aefb4f7/attachment.bin>