[PATCH] D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative

Steve Scalpone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 12:04:10 PDT 2020


sscalpone accepted this revision.
sscalpone added a comment.

In all cases, the compiler must check that the expression used in collapse is positive.  Seems like overkill to create a new expr parser to catch a subset of this check.

The change looks good. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77821/new/

https://reviews.llvm.org/D77821





More information about the llvm-commits mailing list