[PATCH] D78226: [MLIR] Improve support for 0-dimensional Affine Maps.

Jeremy Bruestle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 12:04:06 PDT 2020


jbruestle updated this revision to Diff 257791.
jbruestle marked 3 inline comments as done.
jbruestle added a comment.

Another minor issue found during review


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78226/new/

https://reviews.llvm.org/D78226

Files:
  mlir/lib/Dialect/Vector/VectorTransforms.cpp


Index: mlir/lib/Dialect/Vector/VectorTransforms.cpp
===================================================================
--- mlir/lib/Dialect/Vector/VectorTransforms.cpp
+++ mlir/lib/Dialect/Vector/VectorTransforms.cpp
@@ -1348,7 +1348,6 @@
       auto targetExpr = getAffineDimExpr(idx < index ? idx : idx - 1, ctx);
       results.push_back(targetExpr);
     }
-    // The (...) -> () affine map has its own factory method.
     return AffineMap::get(map.getNumDims() - 1, 0, results, ctx);
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78226.257791.patch
Type: text/x-patch
Size: 499 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200415/191b096b/attachment-0001.bin>


More information about the llvm-commits mailing list