[PATCH] D78130: [SVE] Fixup calls to VectorType::getNumElements() in IR

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 11:30:30 PDT 2020


ctetreau added a comment.

> My concern with switching from getNumElements() to getElementCount() is that we're essentially adding new functionality. That new functionality should have regression test coverage. If we don't do this as we go, we're never going to get reasonable regression test coverage for scalable vectors.

I get where you're coming from, but I think a lot of these cases are actually equivalent. As an exercise, I can speak to each one in this patch individually, and maybe we can work out which need tests and which are NFC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78130/new/

https://reviews.llvm.org/D78130





More information about the llvm-commits mailing list