[PATCH] D78173: MachineFunctionInfo for AArch64 in MIR

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

Code LGTM. Just a few minor nits on the testcases.



================
Comment at: llvm/test/CodeGen/AArch64/function-info-noredzone-present.ll:3
+
+; Here we check taht the noredzone attribute is carried through the machine
+; IR generation and is put in Machine Function Info
----------------
s/taht/that/


================
Comment at: llvm/test/CodeGen/AArch64/function-info-noredzone-present.ll:4
+; Here we check taht the noredzone attribute is carried through the machine
+; IR generation and is put in Machine Function Info
+
----------------
s/Machine Function Info/MachineFunctionInfo/ (someone might grep for the class name, so no spaces is likely better here)


================
Comment at: llvm/test/CodeGen/AArch64/function-info-noredzone-present.ll:8
+  entry:
+    ; CHECK: name:            baz
+    ; CHECK: machineFunctionInfo: {}
----------------
Can you use `CHECK-LABEL` here and for the next function?


================
Comment at: llvm/test/CodeGen/MIR/AArch64/function-info-noredzone-present.mir:3
+
+# This test checks for persistence of the hasRedZone Attribute through a
+# llc transformation that shouldn't do anything
----------------
s/Attribute/attribute/


================
Comment at: llvm/test/CodeGen/MIR/AArch64/function-info-noredzone-present.mir:6
+
+# CHECK-NAME: name:            foo
+# CHECK: machineFunctionInfo: {}
----------------
Can you use `CHECK-LABEL` here?

I think the following `CHECK` line will match the first occurrence of `machineFunctionInfo`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78173/new/

https://reviews.llvm.org/D78173