[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

[George Rimar via Phabricator via llvm-commits]

grimar updated this revision to Diff 257671.
grimar marked an inline comment as done.
grimar added a comment.

- Addressed review comments.
- Refined comments slightly in the test case.

In D78024#1981409 <https://reviews.llvm.org/D78024#1981409>, @jdenny wrote:

> What test suites did you try this on?  It's good to be cautious when increasing FileCheck's strictness.


I used run check-llvm and check-lld previously for this patch.
For the latest diff I've used check-all (which revealed one more test case failture in CodeGen/catch-implicit-conversions-basics-negatives.c)..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78024/new/

https://reviews.llvm.org/D78024

Files:
  clang/test/CodeGen/catch-implicit-conversions-basics-negatives.c
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/test/FileCheck/implicit-check-not.txt
  llvm/test/tools/llvm-objcopy/MachO/strip-debug.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78024.257671.patch
Type: text/x-patch
Size: 6617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200415/b76688a1/attachment.bin>